table widget by Mchris-hub · Pull Request #2 · hein-obox/elementor

Mchris-hub · 2024-02-26T14:45:29Z

PR Checklist

The commit message follows our guidelines: https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

I have tested this code to the best of my abilities
I have added unittests to verify the code works as intended
Docs have been added / updated (for bug fixes / features)

Fixes #

includes/managers/widgets.php

includes/widgets/testOne.php

hein-obox · 2024-04-05T07:33:39Z

includes/widgets/table.php

 	 */
 	public function get_title() {
-		return esc_html__( 'testOne', 'elementor' );
+		return esc_html__( 'table', 'elementor' );


I think we always use capital letters here:

return esc_html__( 'Table', 'elementor' );

I changed it

hein-obox · 2024-04-05T07:34:00Z

includes/widgets/table.php

 	 */
 	public function get_keywords() {
-		return [ 'testOne', 'title', 'text' ];
+		return [ 'table', 'title', 'text' ];


return [ 'table' ];

I removed the 'title' and the 'text'

hein-obox · 2024-04-05T07:34:21Z

includes/widgets/table.php

 			'image_alt' => esc_attr__( 'Upgrade', 'elementor' ),
-			'description' => esc_html__( 'Create captivating testOnes that rotate with the Animated Headline Widget.', 'elementor' ),
-			'upgrade_url' => esc_url( 'https://go.elementor.com/go-pro-testOne-widget/' ),
+			'description' => esc_html__( 'Create captivating tables that rotate with the Animated Headline Widget.', 'elementor' ),


'description' => esc_html__( 'Create captivating tables.', 'elementor' ),

I changed the description

hein-obox · 2024-04-05T07:35:39Z

package.json

 		"eslint-plugin-react": "^7.33.2",
 		"eslint-webpack-plugin": "^4.0.1",
-		"grunt": "^1.5.3",
+		"grunt": "^1.6.1",


Please revert to the orginal value. We can't update packages on the whole repository.

hein-obox · 2024-04-05T07:36:04Z

package-lock.json

 				"eslint-plugin-react": "^7.33.2",
 				"eslint-webpack-plugin": "^4.0.1",
-				"grunt": "^1.5.3",
+				"grunt": "^1.6.1",


Revert changes. We can't make updates here.

I changed it

hein-obox · 2024-04-05T07:36:14Z

package.json

 		"eslint-plugin-react": "^7.33.2",
 		"eslint-webpack-plugin": "^4.0.1",
-		"grunt": "^1.5.3",
+		"grunt": "^1.6.1",


Revert changes. We can't make updates here.

i changed it

hein-obox · 2024-04-05T12:51:14Z

includes/widgets/table.php

+
+				<# if ( settings.list.length ) { #>
+					<tbody>
+						<tr>


Suggested change

<tr>

hein-obox · 2024-04-05T12:51:26Z

includes/widgets/table.php

+				<# if ( settings.list.length ) { #>
+					<tbody>
+						<tr>
+							<# _.each( settings.list, function( item ) { #>


Suggested change

<# _.each( settings.list, function( item ) { #>

<# _.each( settings.list, function( item ) { #>

<tr>

hein-obox · 2024-04-05T12:51:44Z

includes/widgets/table.php

+						<tr>
+							<# _.each( settings.list, function( item ) { #>
+								<td class="elementor-repeater-item-{{ item._id }}">{{{item.list_title}}}</td>
+							<# }); #>


Suggested change

<# }); #>

hein-obox · 2024-04-05T12:51:53Z

includes/widgets/table.php

+							<# _.each( settings.list, function( item ) { #>
+								<td class="elementor-repeater-item-{{ item._id }}">{{{item.list_title}}}</td>
+							<# }); #>
+						</tr>


Suggested change

</tr>

</tr>

<# }); #>

… to row

hein-obox · 2024-04-11T08:17:06Z

includes/widgets/table.php

+		$this->add_control(
+			'rows',
+			[
+				'label' => esc_html__( "Rows' contents", 'elementor' ),


Suggested change

'label' => esc_html__( "Rows' contents", 'elementor' ),

'label' => esc_html__( 'Content rows', 'elementor' ),

I changed it

hein-obox · 2024-04-11T08:17:22Z

includes/widgets/table.php

+			'rows',
+			[
+				'label' => esc_html__( "Rows' contents", 'elementor' ),
+				'show_label' => esc_html__( true, 'elementor' ),


Suggested change

'show_label' => esc_html__( true, 'elementor' ),

'show_label' => true,

I changed it

hein-obox · 2024-04-11T08:17:38Z

includes/widgets/table.php

+						'name' => 'column_content_one',
+						'label' => esc_html__( 'Content column 1', 'elementor' ),
+						'type' => \Elementor\Controls_Manager::TEXT,
+						'default' => esc_html__( 'Content column 1' , 'elementor' ),


Remove default values.

I changed it

hein-obox · 2024-04-11T08:20:18Z

includes/widgets/table.php

+			if ( $settings['rows'] ) {
+					echo '<tbody>';
+					$rows = $settings['rows'];
+					for ($i=0; $i < count($rows) - 1; $i++) { 


I think the rows minus 1 is causing a problem.

Elementor used always spaces in between, check the other files in the repository.

Suggested change

for ($i=0; $i < count($rows) - 1; $i++) {

for ( $i=0; $i < count( $rows ); $i++ ) {

yes I should have put <= like in the JS side

hein-obox · 2024-04-11T08:21:15Z

includes/widgets/table.php

+						<# if ( settings.rows.length ) { #>
+							<tbody>
+								<# let rows = settings.rows #>
+								<# for(let i = 0; i <= rows.length - 1; i++){ #>


Suggested change

<# for(let i = 0; i <= rows.length - 1; i++){ #>

<# for( let i = 0; i <= rows.length - 1; i++ ){ #>

i changed it

hein-obox · 2024-04-11T08:21:31Z

includes/widgets/table.php

+								<# let rows = settings.rows #>
+								<# for(let i = 0; i <= rows.length - 1; i++){ #>
+									<tr>
+										<td class="elementor-repeater-item-{{ rows[i]._id }}">{{{rows[i].column_content_one}}}</td>


Suggested change

<td class="elementor-repeater-item-{{ rows[i]._id }}">{{{rows[i].column_content_one}}}</td>

<td class="elementor-repeater-item-{{ rows[i]._id }}">{{{ rows[i].column_content_one }}}</td>

I changed it

hein-obox · 2024-04-11T08:22:11Z

includes/widgets/table.php

+	 *
+	 * @return array Widget promotion data.
+	 */
+	protected function get_upsale_data() {


i deleted it

…s codes

hein-obox · 2024-04-11T11:05:52Z

package-lock.json

 			}
 		},
 		"node_modules/caniuse-lite": {
-			"version": "1.0.30001532",


Revert changes.

hein-obox · 2024-04-12T09:11:10Z

includes/widgets/table.php

+		$this->add_control(
+			'table_head_color',
+			[
+				'label' => esc_html__( 'Table head Color', 'elementor' ),


Use labels from Trello.

Using the correct lowercase vs uppercase is important. You can't mix it randomly.

table widget

ae22572

Mchris-hub marked this pull request as draft February 26, 2024 14:45

hein-obox reviewed Feb 26, 2024

View reviewed changes

includes/managers/widgets.php Outdated Show resolved Hide resolved

hein-obox reviewed Feb 26, 2024

View reviewed changes